Automate kubevirt_vmi_phase_transition_time_from_deletion_seconds metrics#3128
Automate kubevirt_vmi_phase_transition_time_from_deletion_seconds metrics#3128rnetser merged 13 commits intoRedHatQE:mainfrom
Conversation
WalkthroughAdds two Prometheus metric constants (bucket and count) for VMI phase-transition-from-deletion, snapshots three deletion metrics via a new class-scoped fixture, changes Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-3128 published |
|
/lgtm |
|
/verified tests-runner 4.21 #4166 with |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 6588 🏁 Script executed: Length of output: 1728 🧠 Learnings used |
|
/lgtm cancel |
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-3128 published |
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-3128 published |
|
/verified with tests-runner 4.21 using |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 6689 🏁 Script executed: Length of output: 1728 🧠 Learnings used |
|
/lgtm |
|
/approve |
|
/lgtm |
|
Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-3128. |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published |
Short description:
creating tests for kubevirt_vmi_phase_transition_time_from_deletion_seconds_count and kubevirt_vmi_phase_transition_time_from_deletion_seconds_bucket, consolidating with existing kubevirt_vmi_phase_transition_time_from_deletion_seconds_sum
More details:
What this PR does / why we need it:
part of https://issues.redhat.com/browse/CNV-42265, updating granularity of phase metrics
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
https://issues.redhat.com/browse/CNV-75207
Summary by CodeRabbit
New Features
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.